ontology type is wrong with the very latest model #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keeping the previous type in there just in case
mart-r
approved these changes
Sep 27, 2022
|
Yep tbh - I don't think we had a model that actually used this config
setting before, so it probably always should have been a List[str] rather
than str - but nvm, we need to support str for backwards compatibility for
a couple of versions
…On Tue, 27 Sept 2022 at 09:08, mart-r ***@***.***> wrote:
***@***.**** approved this pull request.
Thanks for fixing this. Looks good to me.
But in the hypothetical future we'd probably want to create tests that
cover the part of the project where the erroneous behaviour would have been
caught before my PR.
—
Reply to this email directly, view it on GitHub
<#267 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABRTZNHXINVNQSXLFJJZCL3WAKTRLANCNFSM6AAAAAAQWCCPQQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
mart-r
pushed a commit
to mart-r/MedCAT
that referenced
this pull request
Jun 14, 2023
ontology type is wrong with the very latest model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping the previous type in there just in case